-
Notifications
You must be signed in to change notification settings - Fork 1
Hdpi 2036 statement of truth screen english journey #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hdpi 2036 statement of truth screen english journey #918
Conversation
CCD diff summary👉 Full report: https://github.com/hmcts/pcs-api/actions/runs/19241027768?check_suite_focus=true CaseField.json
AuthorisationCaseField/caseworker-pcs-solicitor.json
CaseEventToFields/resumePossessionClaim.json
CaseEventToFields/enforceTheOrder.json
FixedLists/StatementOfTruthCompletedBy.json
FixedLists/StatementOfTruthAgreementLegalRep.json
FixedLists/StatementOfTruthAgreementClaimant.json
|
CCD diff summary👉 Full report: https://github.com/hmcts/pcs-api/actions/runs/19241488861?check_suite_focus=true CaseField.json
AuthorisationCaseField/caseworker-pcs-solicitor.json
CaseEventToFields/resumePossessionClaim.json
CaseEventToFields/enforceTheOrder.json
FixedLists/StatementOfTruthCompletedBy.json
FixedLists/StatementOfTruthAgreementLegalRep.json
FixedLists/StatementOfTruthAgreementClaimant.json
|
|
|
||
| private String positionClaimant; | ||
|
|
||
| private List<String> agreementLegalRep; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
src/main/java/uk/gov/hmcts/reform/pcs/ccd/page/makeaclaim/StatementOfTruth.java
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/reform/pcs/ccd/service/StatementOfTruthService.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/reform/pcs/ccd/domain/StatementOfTruthAgreementLegalRep.java
Outdated
Show resolved
Hide resolved
- Created StatementOfTruthDetails complex type to group related fields - Refactored PCSCase to use StatementOfTruthDetails instead of 8 individual fields - Updated StatementOfTruthService to access nested fields - Updated StatementOfTruth page configuration to use complex type with auto-set logic - Removed redundant @ccd annotations from enum classes (using HasLabel instead) - Updated tests to work with new nested structure
CCD diff summary👉 Full report: https://github.com/hmcts/pcs-api/actions/runs/19262643318?check_suite_focus=true CaseField.json
AuthorisationCaseField/caseworker-pcs-solicitor.json
ComplexTypes/0_VulnerableAdultsChildren.json
ComplexTypes/StatementOfTruthDetails.json
CaseEventToFields/resumePossessionClaim.json
CaseEventToFields/enforceTheOrder.json
FixedLists/VulnerableCategory.json
FixedLists/StatementOfTruthCompletedBy.json
FixedLists/StatementOfTruthAgreementLegalRep.json
FixedLists/StatementOfTruthAgreementClaimant.json
|
…-of-truth-screen-english-journey
CCD diff summary👉 Full report: https://github.com/hmcts/pcs-api/actions/runs/19263208227?check_suite_focus=true CaseField.json
AuthorisationCaseField/caseworker-pcs-solicitor.json
ComplexTypes/StatementOfTruthDetails.json
CaseEventToFields/resumePossessionClaim.json
FixedLists/StatementOfTruthCompletedBy.json
FixedLists/StatementOfTruthAgreementLegalRep.json
FixedLists/StatementOfTruthAgreementClaimant.json
|
CCD diff summary👉 Full report: https://github.com/hmcts/pcs-api/actions/runs/19264306892?check_suite_focus=true CaseField.json
AuthorisationCaseField/caseworker-pcs-solicitor.json
ComplexTypes/StatementOfTruthDetails.json
CaseEventToFields/resumePossessionClaim.json
FixedLists/StatementOfTruthCompletedBy.json
FixedLists/StatementOfTruthAgreementLegalRep.json
FixedLists/StatementOfTruthAgreementClaimant.json
|
CCD diff summary👉 Full report: https://github.com/hmcts/pcs-api/actions/runs/19265130371?check_suite_focus=true CaseField.json
AuthorisationCaseField/caseworker-pcs-solicitor.json
ComplexTypes/StatementOfTruthDetails.json
CaseEventToFields/resumePossessionClaim.json
FixedLists/StatementOfTruthCompletedBy.json
FixedLists/StatementOfTruthAgreementLegalRep.json
FixedLists/StatementOfTruthAgreementClaimant.json
|
- Changed mapToLabels() to mapToNames() to persist enum names (BELIEVE_TRUE, AGREED) instead of label strings - This ensures backward compatibility if labels change in the future - Updated tests to expect enum names instead of labels
CCD diff summary👉 Full report: https://github.com/hmcts/pcs-api/actions/runs/19266015747?check_suite_focus=true CaseField.json
AuthorisationCaseField/caseworker-pcs-solicitor.json
ComplexTypes/StatementOfTruthDetails.json
CaseEventToFields/resumePossessionClaim.json
FixedLists/StatementOfTruthCompletedBy.json
FixedLists/StatementOfTruthAgreementLegalRep.json
FixedLists/StatementOfTruthAgreementClaimant.json
|
CCD diff summary👉 Full report: https://github.com/hmcts/pcs-api/actions/runs/19266114131?check_suite_focus=true CaseField.json
AuthorisationCaseField/caseworker-pcs-solicitor.json
ComplexTypes/StatementOfTruthDetails.json
CaseEventToFields/resumePossessionClaim.json
FixedLists/StatementOfTruthCompletedBy.json
FixedLists/StatementOfTruthAgreementLegalRep.json
FixedLists/StatementOfTruthAgreementClaimant.json
|
…-of-truth-screen-english-journey
CCD diff summary👉 Full report: https://github.com/hmcts/pcs-api/actions/runs/19266741086?check_suite_focus=true CaseField.json
AuthorisationCaseField/caseworker-pcs-solicitor.json
ComplexTypes/StatementOfTruthDetails.json
CaseEventToFields/resumePossessionClaim.json
FixedLists/StatementOfTruthCompletedBy.json
FixedLists/StatementOfTruthAgreementLegalRep.json
FixedLists/StatementOfTruthAgreementClaimant.json
|
…Truth - Changed agreementClaimant and agreementLegalRep from List<String> to String - Updated StatementOfTruthService to use mapToFirstName() method - Removed unused mapToNames() method - Updated tests to expect String values instead of List - Verified with local database that data is stored correctly as strings
…undForPossessionAdditionalGrounds
Co-authored-by: jors95-moj <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lovelin <[email protected]> Co-authored-by: madhavi1203 <[email protected]> Co-authored-by: Praveen Adusumilli <[email protected]> Co-authored-by: MoLala1 <[email protected]>
Jira link
HDPI-2036
Statement of Truth Screen for English journey
Change description
New page Statement of truth
Testing done
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist